search

5zig-reborn / The-5zig-Mod

All-in-one modification for Minecraft 1.8.9-1.15.2
https://5zigreborn.eu
GNU General Public License v3.0
109 stars 12 forks source link

Oversaturation icons are buggy when entering and/or exiting water #121

Open Andre601 opened 4 years ago

Andre601 commented 4 years ago

Describe the bug This is mostly a visual bug and fixing of it is obviously not a high priority for me, so feel free to tackle this whenever.

The bug is, that the oversaturation disappears and reappears when entering and leaving a body of water. This is (I assume) expected as the bubbles while swimming underwater appear on that exact position. The problem with this is, that with the swim and water changes introduced in MC 1.13 was the disappearing of bubbles changed. Unlike before where it was instant will they now disappear after they have been refilled. This causes the weird behaviour, where the bubbles show over the oversaturation icons as those are set to instantly reappear after you leave the water.

I have suggestions on how this could be fixed.

1) Make the bubbles appear over the oversaturation If possible could you rearange the position of the bubbles to be over the new row of saturation. This would obviously look a bit odd tho.

2) New icon for oversaturation I personally would go for this one if feasible. Just change the saturation icon of vanilla minecraft to a different one (Different outline or icon) when it is oversaturated, similar to what certain mods out there do (for other things than oversaturation).

To Reproduce Steps to reproduce the behavior:

  1. Have showing of oversaturation activated
  2. Go into water
  3. Swim around underwater
  4. Go out of the water while bubbles are recharging

Expected behavior The icons shouldn't overlap

Screenshots image

Desktop (please complete the following information):

Additional context As I mentioned at the beginning can this be treated as a low priority issue as it is only a minor visual issue and doesn't break the game in a bad way. I just wanted to post this here to have it "logged" and not possibly lost in other places like Discord chat.

i-bug-you[bot] commented 4 years ago

Thank you for opening this bug report. A member of the testing group will try to reproduce it as soon as possible. @U5B, @waterswimmer111, @Motschen

roccodev commented 4 years ago

Thank you. I'm trying to think of other ways too, I had in mind to render the bubbles above the hearts, but maybe it'd look odd with health boost. Perhaps render the saturation row above the bubbles?

Andre601 commented 4 years ago

Thank you. I'm trying to think of other ways too, I had in mind to render the bubbles above the hearts, but maybe it'd look odd with health boost. Perhaps render the saturation row above the bubbles?

Would both look odd. In addition would the heart option also (maybe) conflict with when you're wearing armor. I believe it should actually be reduced a bit imo. What is even the max oversaturation you can get without any unnatural way (i.e. saturation potion effect)? Because from what I know will there always empty hunger icons remain even when using an item with highest feed value on only half a hunger icon loss.

I would still go for the option to change the icon displayed for hunger when having oversaturation on it (if possible that is)