search

5zig / Bungee-Reconnect

A simple BungeeCord-Plugin that automatically tries to reconnect all players whenever a server restarts.
20 stars 12 forks source link

Removed static ab00se #6

Closed ghost closed 8 years ago

ghost commented 8 years ago

Fixed Regex stuff

5zig commented 8 years ago

Hey, thank you for your pull request. I agree with you that using a singleton isn't that good and should be replaced. Still, I think that your changes to the regex stuff are rather slow in performance and may provoke errors since String.match() needs to compile the regex-pattern every time. Long or invalid patterns would cause unpredictable consequences. As of that, could you please create a new commit, containing only your changes to the singleton class? Otherwise I would need to merge your changes first and revert part of it afterwards again... Thanks in advance!

Krymonota commented 8 years ago

Hey, everything that needs to be said has already been said. I created now a pull request (along with some other commits), in order to ensure an update as fast as possible because a critical bug has been fixed.

Just a quick tip for the future: Please avoid pushing several changes as one commit, so we can pick the commits that we need using git-cherry-pick.

However, thank you for your help!

5zig commented 8 years ago

I've merged the pull request from Krymonota now, who basically implemented all your static changes together with some little fixes. Still, I'd like to thank you for you help.