search

607011 / Qt-SESAM

c't SESAM Password Manager (Qt version)
http://607011.github.io/Qt-SESAM/
GNU General Public License v3.0
77 stars 29 forks source link

With a fresh install after entering 1st domain: spinner is shown, password field is empty #68

Closed 607011 closed 9 years ago

607011 commented 9 years ago

Quick'n'dirty remedy: reselect domain in combobox.

607011 commented 9 years ago

Reselecting works only in some cases.

607011 commented 9 years ago

This seems to be a concurrency issue.

607011 commented 9 years ago

@Wikinaut reported that problem is still present.

Exploring …

607011 commented 9 years ago

Could not reproduce the reported bug by doing the following after a fresh install (i.e. no settings file present, not sync file or server set up):

Observations: All fields are correctly transferred to the main window. Password is generated. Spinner hidden after generation.

Successfully tested on:

Nonetheless, I could reproduce the bug by entering a new domain via Ctrl+N.

Wikinaut commented 9 years ago

Tjs, what shall I say?

607011 commented 9 years ago

I think I found the bug. Stay tuned.

607011 commented 9 years ago

Wahoooooo! That was a difficult birth ;-)

607011 commented 9 years ago

Bug fixed in branch Issue-68.

Works on openSUSE Tumbleweed and Windows 7.

Can anyone confirm?@Wikinaut?

Please

git pull origin Issue-68
git checkout Issue-68

then build and test!

607011 commented 9 years ago

Resolved by commit a8d0cdf111a6de491de254430f95bc1dbd30195b.

Wikinaut commented 9 years ago

The endless-loop is gone. The problem with new domains still present. I added a first new domain, closed the program and restarted- Okay. Then New Domain. Tried to enter a new domain -- no way, it does not work. No password generated, or not saved, cannot track --- too many problems with this program.

CORRECTION: https://github.com/ola-ct/Qt-SESAM/issues/56 is not solved.

Wikinaut commented 9 years ago

make warning:

In file included from ../../../../include/qt5/QtCore/qnamespace.h:37:0,
                 from ../../../../include/qt5/QtCore/qobjectdefs.h:41,
                 from ../../../../include/qt5/QtCore/qobject.h:40,
                 from ../../../../include/qt5/QtCore/QObject:1,
                 from ../libSESAM/util.h:25,
                 from optionsdialog.cpp:20:
optionsdialog.cpp: In member function ‘void OptionsDialog::onServerRootUrlChanged(QString)’:
../../../../include/qt5/QtCore/qglobal.h:979:43: warning: unused variable ‘d’ [-Wunused-variable]
 #define Q_D(Class) Class##Private * const d = d_func()
                                           ^
optionsdialog.cpp:244:3: note: in expansion of macro ‘Q_D’
   Q_D(OptionsDialog);
Wikinaut commented 9 years ago

I guess, you have to refactor your program. From scratch.

607011 commented 9 years ago

Tested latest commit on Xubuntu 15.04, Xubuntu 14.10, openSUSE Tumbleweed, Windows 7. Compiles fine. Runs fine. Neither #56 nor #68 appears.

607011 commented 9 years ago

Tested on another Ubuntu 15.04 (physical machine, not VM): no problems.

607011 commented 9 years ago

Tested on late 2011 MacBookPro running Mac OS X 10.10.5 and Qt 5.5.0: no problems.