#52 - Make client compiler optional

60frames / webpack-hot-server-middleware

:fire: Hot reload webpack bundles on the server

MIT License

324 stars 50 forks source link

#52 - Make client compiler optional #59

Closed roastlechon closed 6 years ago

roastlechon commented 6 years ago

Addresses issue #52.

Removes the throw for not finding a client compiler
Adds debug message if not able to find a client compiler
Wrap client stats retrieval with a check for clientCompiler length
Fixes unit tests

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 3eb7d2fca70a0baa71810e8e177b5e0eebd27d89 on roastlechon:feature/52-make-client-compiler-optional into 299e63585f969e80484dae82acd6dc64f90fd665 on 60frames:master.

richardscarrott commented 6 years ago

@roastlechon Thanks for the PR, I plan on taking a look over it this week.

richardscarrott commented 6 years ago

@roastlechon that's merged and published in v0.4.0 -- thanks for the contribution 👍