616b2f / IdentityServer4.WsFederation

Sample for implementing WS-Federation IdP support for IdentityServer4 using ASP.NET Core
Apache License 2.0
6 stars 9 forks source link

Bug in ReturnUrlParser: Parameter wtrealm is always null #7

Closed jesslilly closed 3 years ago

jesslilly commented 3 years ago

See issue in my fork https://github.com/jesslilly/IdentityServer4.WsFederation/issues/1 This is the same issue as https://github.com/616b2f/IdentityServer4.WsFederation/pull/3, but this fix is better since it is less hacky and has unit tests.

616b2f commented 3 years ago

sorry I was to fast on the replies. The PR #3 is a good one because it does not add much code and uses the WsFederationMessage functionality that is already well tested.

Anyway, thank you for your time and contribution!