62832 / AppliedE

Direct ProjectE EMC integration with Applied Energistics 2.
https://curseforge.com/minecraft/mc-mods/appliede
GNU Lesser General Public License v3.0
6 stars 5 forks source link

Server Crash #3

Closed TheOddball closed 6 months ago

TheOddball commented 6 months ago

Hello Ninety!

It appears as though AppliedE is crashing my Minecraft server. I have uploaded the crashlog below. Unfortunately, due to the nature of this crash, I cannot login in order to investigate exact details of my setup.

I have gotten back into my server and identified the main steps to get this crash to occur. I currently have 1.8G of EMC in my Table, and specifically what I did to cause this crash was; Enter the portal in The End (returning to overworld). I avoided this crash by manually editing my player NBT data back to overworld from the_end.

crash-2024-05-05_02.23.34-server.txt

62832 commented 6 months ago

I'm not entirely certain, but this looks to be a problem with ProjectE itself. I'll let the guys in charge of that mod know as well that this is happening and see if anything can be done from their end.

TheOddball commented 6 months ago

I'm not entirely certain, but this looks to be a problem with ProjectE itself. I'll let the guys in charge of that mod know as well that this is happening and see if anything can be done from their end.

That's certainly interesting! Thank you for being so timely in investigating this matter :)

62832 commented 6 months ago

Hello again. My suspicions were pretty much confirmed that this is a problem on ProjectE's end. What they're currently doing to query player capabilities for knowledge and EMC actually throws an exception altogether if the cap can't be found, which just so happens to happen when a player on the server is dead.

For the time being, I've rolled out my own fix in the add-on involving a mixin that replaces the offending method with a near-identical copy that instead returns the offline provider instance for that player rather than throwing. However, since I'm not entirely satisfied with this approach I'm going to leave this issue open until the problem is fixed upstream.

TheOddball commented 6 months ago

Thank you for fixing this issue so quickly! Major kudos. I'll put together a new version of our pack with the update. Thank you!

62832 commented 6 months ago

Just a heads up, you should use the next update coming in a few minutes rather than this one since I fucked something up on my end earlier. Look out for 0.6.4-beta coming up.

TheOddball commented 6 months ago

Will do!

TheOddball commented 6 months ago

crash-2024-05-05_15.25.10-server.txt Uhoh! New crash relating to AE2 after updating to 0.6.4 :( The block at that location is the Transmutation Module

62832 commented 6 months ago

Yeah, I got alerted to it later as well. Turns out my previous already-too-intrusive approach didn't really work in the end and I'm replacing it with something more robust. Give it a few minutes to release.

TheOddball commented 6 months ago

After updating to 0?6.5, all crashing issues have stopped occuring! Thank you!

TheOddball commented 6 months ago

Good afternoon - We are updating our pack today and it seems AppliedE is crashing our server again :(

crash-2024-05-13_16.33.49-server.txt

62832 commented 6 months ago

My apologies. Would you tell me if the previous version causes any crashes? You might need to temporarily remove any Transmutation Modules and replace them after updating back to the latest.

62832 commented 6 months ago

Alternatively, see if the upcoming release fixes it, and if not please let me know.

TheOddball commented 6 months ago

I had tested with 0.11.1 instead of .3, and it still crashed. Upon updating to 0.11.4, I am now getting a different crash :( crash-2024-05-14_10.45.08-server.txt

I tried to break the block > update > replace it, and the server did successfully start when it was broken - however, upon placing, the server instantly crashes. crash-2024-05-14_11.06.23-server.txt

62832 commented 6 months ago

The only thing I can suggest is rolling back to whatever version worked last and removing any Transmutation Modules before updating and then placing them back.

Unfortunately, I haven't been able to reproduce this in either my development environment or on another large modpack's test server, and I can only assume this is just a consequence of how frequently (and admittedly rather haphazardly) I've had to change different things around internally.

62832 commented 6 months ago

I tried to break the block > update > replace it, and the server did successfully start when it was broken - however, upon placing, the server instantly crashes.

Okay, now this I think might be on me and fixable, I hope. Give me a few minutes.

TheOddball commented 6 months ago

Also - now the server wont start on the old version 😆

62832 commented 6 months ago

Oooookay. As a last resort, do you think you'd be able to clear any of the transmutable item knowledge for any players with modules installed, and even EMC if necessary?

TheOddball commented 6 months ago

I do not mind waiting for a potential fix included in 0.11.5 :) I am the only player with the module and/or EMC, so it wouldnt be a huge issue