Incorrect error logging for factory modules

[GoogleCodeExporter]

The ErrorManager has two overloaded logError messages, which are similar:
  public void logError(String message, Object... args) {

  public void logError(String message, Throwable t, Object... args) {

The current code uses the first method. Parameter 2+3 are passed as args. The 
third arg is never used. It seems that the intention was to use the second 
method, where all three parameters get used. To achieve that, parameter 2+3 
have to switch place.

Thomas
tfischer@google.com

Original issue reported on code.google.com by tfisc...@google.com on 2 Jul 2011 at 1:28

Attachments:

• BindingsProcessor.java.patch

[GoogleCodeExporter]

Looks good to me, I'll patch this and submit it.

Original comment by aragos on 19 Jul 2011 at 5:08

• Changed title: Incorrect error logging for factory modules
• Changed state: Review
• Added labels: Priority-Low, Type-Defect
• Removed labels: Type-Patch

[GoogleCodeExporter]

Submitted and fixed in r220. Thanks for the patch!

Original comment by aragos on 19 Jul 2011 at 5:14

• Changed state: Fixed