search

64bandil / merlin400

Open source project for the Merlin400 extractor
GNU General Public License v3.0
12 stars 3 forks source link

valves not closing correctly after venting #5

Open proodle opened 1 month ago

proodle commented 1 month ago

I am using FW: 1.0-preview1.

According to the dashboard, the valves have a default position like this: Valve 1: Open (0) Valve 2: Closed (100) Valve 3: Closed (100) Valve 4: Closed (100)

When I run the "Vent Pump" command, valve 4 opens and closes. I guess this is correct. But after the full venting procedure has finished, the valve positions are: Valve 1: Open (0) Valve 2: Open (0) Valve 3: Open (0) Valve 4: Closed (100)

I think the vents should be in the same position like they were before running the procedure.

andulv commented 1 month ago

I think this is the same behavior as in the original drizzle software, I have not touched the code that is close to the hardware and executes the predefined programs.

From a quick test it seems like this also applies to other programs (vents do not always revert to default positions after program has completed or failed).

I agree with you that it seems correct that vents should revert to default position after this program (and probably also all other programs) has completed.

BTW: I think I switched around open and closed in preview1. This has been fixed in preview2 where 0=Open and 100=Closed which I think is correct. Please correct me if this seems wrong to you. :)

proodle commented 1 month ago

First of all, thank you for your excellent work. On my machine I have already fully replaced the original software with yours. I would prefer not to see the "0" and "100" values at all,because they are confusing. Instead I suggest to show the state (open or closed) and a green or red ball to indicate if the valve is open or closed.