add support for base64 embeddings

64bit / async-openai

Rust library for OpenAI

https://docs.rs/async-openai

MIT License

1.11k stars 165 forks source link

Closed adri1wald closed 6 months ago

adri1wald commented 7 months ago

Resolves #189

Considerations:

Instead of using a generic could copy pasta the whole response struct for Base64 embeddings. This was less code, but leaks some implementation details out of the crate.
Left the debug assert in - lmk if you want it removed
Open to any other suggestions :)

64bit commented 7 months ago

Thank you for the PR!

Looking at the spec doesn't distinguishes base64 response - it opens up implementation details - which you have done nicely!

I'll leave the comments about your considerations separately.

adri1wald commented 6 months ago

@64bit Sorry about the delay. I think this is ready for another review now! Let me know what you think :)