Fix #10 - Enable update and security mirrors for target system

64studio / dibby

Generate Custom Debian images for your embedded projects

BSD 3-Clause "New" or "Revised" License

8 stars 2 forks source link

Fix #10 - Enable update and security mirrors for target system #15

Closed danielhjames closed 5 years ago

danielhjames commented 5 years ago

Also:

Echo the dibby command arguments and mirror to confirm user choices Offer alternative of sudo when permissions are insufficient

Tested on Debian 9.8 'stretch' build host.

danielhjames commented 5 years ago

As there are only a limited number of suites with update and security support from Debian, the check added in https://github.com/64studio/dibby/pull/15/commits/5189862638b295611dae07a3cd93b360bc52b134 should prevent these extra repos being added in other cases.

obbardc commented 5 years ago

Looks good,

I think I'm more inclined to include APT repo in default-config to allow the user to override it. This would then work for future sources like Ubuntu, Debian, Mint.

e.g

APT_SOURCES_LIST="
deb http://deb.debian.org/debian sid main
deb-src http://deb.debian.org/debian sid main
"

Also, how about using printenv to print the configuration after it's been loaded in? Some grepping could be done for our variables. e.g all variables set by our script.

danielhjames commented 5 years ago

I've added printing of more of the user variables and tightened up the root password setting. Hopefully it shouldn't be necessary for the user to specify the whole sources.list as the format follows a known pattern, but let's see.