search

64studio / pdk-mediagen

Next-generation media generation for PDK
0 stars 0 forks source link

after image generation, image is still in tmp folder & tmp folder is not deleted #7

Closed obbardc closed 6 years ago

obbardc commented 6 years ago

image should be moved after completion to the file specified in the component meta file.

tmp folder should be removed after completion

obbardc commented 6 years ago

Also the image has not got the right owner or permissions.

danielhjames commented 6 years ago

Maybe we need a command something like 'make release' to perform the image move, as we might need to test that image in tmp/ before releasing it to the users. Should 'make clean' remove the tmp/ directory and previously built images? Or is that too risky if someone has not made the release yet?

obbardc commented 6 years ago

The "pdk mediagen" command accepts an output location argument, and there is also a failback output location included with the meta in the xml file.

Currently, pdk-mediagen does not follow these commands and just places the image in the "tmp" directory.

I agree with the make release comment: in the project makefile we should have a "make develop" and "make release"

obbardc commented 6 years ago

I've opened a separate issue to create a common makefile: https://github.com/64studio/pdk/issues/42

obbardc commented 6 years ago

This is now fixed.