search

6529-Collections / nftdelegation

Delegation contract
MIT License
16 stars 7 forks source link

Custom errors are more gas efficient than using require #25

Closed rookmate closed 1 year ago

rookmate commented 1 year ago

This PR tackles clarity on why the function reverted instead of a generic require failure.

Issue #26 relates to this PR.

brookr commented 1 year ago

Looks good, I like this better than comparing a boolean with a boolean (thing == false).

rookmate commented 1 year ago

Updated to fit with the new code updates @skyn3t2030

skyn3t2030 commented 1 year ago

The team decided not to proceed with this change as its increases the contract code size as well as the execution cost when an execution fails.