Version 5.20.3 of the code is very hard to read due to poor indentation

[rookmate]

The indentation of the current code makes it very hard to read what is inside each for loop and inside each if else statement.

I think it would improve the quality of the code if it was indented correctly as it would also make it more readable. I will open a PR for this version.

EDIT: There is also a lack of consistency on assignments and comparisons. Eg. varible=0 vs variable = 0

I propose to use the C standard. Example 1: variables are to be spaced from operators variable = 0

Example 2: Indentation inside brackets have one additional tab Example 3: Spacing after a closed bracket and conditional or loop

if (something) {
    (...)
}

[rookmate]

See PR #28

[rookmate]

Thoughts? @skyn3t2030 @brookr

[brookr]

Yes! Very important for readability and clarity, and therefore bug reduction.

@skyn3t2030: Do you like this style guide proposal? I'll add that to the contributing guide if so.

[skyn3t2030]

Guys thanks for your comments. Please allow me some days as I am currently working on a newer version that optimizes the functionality of the smart contract for specific usecases and then we can fix indentation :)

[rookmate]

Ok, so I will drop the PR #28. When you update the code I'll redo it 👍

@skyn3t2030 before you update to the next version, also check my 2 other issues. They are minor updates that are nice to have

[skyn3t2030]

agree, will do thanks

[brookr]

Could we standardize on using something like Prettier in local dev environments?

• https://github.com/prettier-solidity/prettier-plugin-solidity
• I'm using this one: https://marketplace.visualstudio.com/items?itemName=JuanBlanco.solidity

We can add one of these to support linting:

• https://github.com/protofire/solhint
• https://github.com/duaraghav8/Ethlint

[brookr]

Let's close this one, @rookmate, with what has been merged and current PR, we are in good shape!

The hardhat ext in VS Code ("Solidity by Nomic Foundation") provides a formatter and linter. Let's go with that.