search

65MO / Galaxy-E

Towards a Galaxy for Ecology
Other
6 stars 11 forks source link

add parameters input in the french file as well #49

Closed sbenateau closed 4 years ago

sbenateau commented 5 years ago

The end of the update of the flight curve tool

yvanlebras commented 5 years ago

sorry if I mis something... You already modified / updated the R script before so these 2 options are usable ?

sbenateau commented 5 years ago

Yes I was working directly on 65MO/Galaxy-E before (which wasn't a good idea). I had forgotten this file so I do it the right way.

yvanlebras commented 5 years ago

ok, fine for me. Thanks !!! I let @Alanamosse for review and merge

Alanamosse commented 5 years ago

$MinVisit $MinOccur are integer parameters so quotes are not needed

Alanamosse commented 5 years ago

Maybe you also want to set a minimum to zero ?

sbenateau commented 5 years ago

Both comments are super relevant ! Thank you very much Alan

yvanlebras commented 5 years ago

you rock guys !

sbenateau commented 5 years ago

@Alanamosse I added some changes (file type, your recommendations). Maybe you could have some comments.

sbenateau commented 5 years ago

@Alanamosse I made the changes you proposed (I think it is useful to make the choice of the separator automatic) I was however unable to add the package in the requirement part...