664235822
commented
1 year ago WIndowsRunnableTHread.h file has some code error，there is my WindowsRunnableThread.h file in ue 4.27, please check out. // Copyright Epic Games, Inc. All Rights Reserved.
pragma once
include "CoreTypes.h"
include "HAL/PlatformProcess.h"
include "Containers/StringConv.h"
include "HAL/Event.h"
include "HAL/Runnable.h"
include "HAL/RunnableThread.h"
include "HAL/ThreadManager.h"
include "CoreGlobals.h"
include "Windows/WindowsHWrapper.h"
include "HAL/LowLevelMemTracker.h"
class FRunnable;
/**
- This is the base interface for all runnable thread classes. It specifies the
-
methods used in managing its life cycle. */ class FRunnableThreadWin : public FRunnableThread { /* The thread handle for the thread. / HANDLE Thread;
/**
- The thread entry point. Simply forwards the call on to the right
- thread main function / static DWORD STDCALL _ThreadProc( LPVOID pThis ) { check(pThis); auto ThisThread = (FRunnableThreadWin*)pThis; FThreadManager::Get().AddThread(ThisThread->GetThreadID(), ThisThread); return ThisThread->GuardedRun(); }
/* Guarding works only if debugger is not attached or GAlwaysReportCrash is true. / uint32 GuardedRun();
/**
- The real thread entry point. It calls the Init/Run/Exit methods on
- the runnable object */ uint32 Run();
public:
FRunnableThreadWin( )
: Thread(NULL)
{}
~FRunnableThreadWin( )
{
// Clean up our thread if it is still active
if (Thread != NULL)
{
Kill(true);
}
}
static int TranslateThreadPriority(EThreadPriority Priority)
{
switch (Priority)
{
case TPri_AboveNormal: return THREAD_PRIORITY_HIGHEST;
case TPri_Normal: return THREAD_PRIORITY_HIGHEST - 1;
case TPri_BelowNormal: return THREAD_PRIORITY_HIGHEST - 3;
case TPri_Highest: return THREAD_PRIORITY_HIGHEST;
case TPri_TimeCritical: return THREAD_PRIORITY_HIGHEST;
case TPri_Lowest: return THREAD_PRIORITY_HIGHEST - 4;
case TPri_SlightlyBelowNormal: return THREAD_PRIORITY_HIGHEST - 2;
default: UE_LOG(LogHAL, Fatal, TEXT("Unknown Priority passed to TranslateThreadPriority()")); return TPri_Normal;
}
}
virtual void SetThreadPriority( EThreadPriority NewPriority ) override
{
// Don't bother calling the OS if there is no need
ThreadPriority = NewPriority;
// Change the priority on the thread
::SetThreadPriority(Thread, TranslateThreadPriority(ThreadPriority));
}
virtual void Suspend( bool bShouldPause = true ) override
{
check(Thread);
if (bShouldPause == true)
{
SuspendThread(Thread);
}
else
{
ResumeThread(Thread);
}
}
virtual bool Kill( bool bShouldWait = false ) override
{
check(Thread && "Did you forget to call Create()?");
bool bDidExitOK = true;
// Let the runnable have a chance to stop without brute force killing
if (Runnable)
{
Runnable->Stop();
}
// If waiting was specified, wait the amount of time. If that fails,
// brute force kill that thread. Very bad as that might leak.
if (bShouldWait == true)
{
// Wait indefinitely for the thread to finish. IMPORTANT: It's not safe to just go and
// kill the thread with TerminateThread() as it could have a mutex lock that's shared
// with a thread that's continuing to run, which would cause that other thread to
// dead-lock. (This can manifest itself in code as simple as the synchronization
// object that is used by our logging output classes. Trust us, we've seen it!)
WaitForSingleObject(Thread,INFINITE);
}
// Now clean up the thread handle so we don't leak
CloseHandle(Thread);
Thread = NULL;
return bDidExitOK;
}
virtual void WaitForCompletion( ) override
{
// Block until this thread exits
WaitForSingleObject(Thread,INFINITE);
}protected:
virtual bool CreateInternal( FRunnable* InRunnable, const TCHAR* InThreadName,
uint32 InStackSize = 0,
EThreadPriority InThreadPri = TPri_Normal, uint64 InThreadAffinityMask = 0,
EThreadCreateFlags InCreateFlags = EThreadCreateFlags::None) override
{
static bool bOnce = false;
if (!bOnce)
{
bOnce = true;
::SetThreadPriority(::GetCurrentThread(), TranslateThreadPriority(TPri_Normal)); // set the main thread to be normal, since this is no longer the windows default.
}
check(InRunnable);
Runnable = InRunnable;
ThreadAffinityMask = InThreadAffinityMask;
// Create a sync event to guarantee the Init() function is called first
ThreadInitSyncEvent = FPlatformProcess::GetSynchEventFromPool(true);
ThreadName = InThreadName ? InThreadName : TEXT("Unnamed UE4");
ThreadPriority = InThreadPri;
// Create the new thread
{
LLM_SCOPE(ELLMTag::ThreadStack);
LLM_PLATFORM_SCOPE(ELLMTag::ThreadStackPlatform);
// add in the thread size, since it's allocated in a black box we can't track
LLM(FLowLevelMemTracker::Get().OnLowLevelAlloc(ELLMTracker::Default, nullptr, InStackSize));
LLM(FLowLevelMemTracker::Get().OnLowLevelAlloc(ELLMTracker::Platform, nullptr, InStackSize));
// Create the thread as suspended, so we can ensure ThreadId is initialized and the thread manager knows about the thread before it runs.
Thread = CreateThread(NULL, InStackSize, _ThreadProc, this, STACK_SIZE_PARAM_IS_A_RESERVATION | CREATE_SUSPENDED, (DWORD *)&ThreadID);
}
// If it fails, clear all the vars
if (Thread == NULL)
{
Runnable = nullptr;
}
else
{
ResumeThread(Thread);
// Let the thread start up
ThreadInitSyncEvent->Wait(INFINITE);
ThreadPriority = TPri_Normal; // Set back to default in case any SetThreadPrio() impls compare against current value to reduce syscalls
SetThreadPriority(InThreadPri);
}
// Cleanup the sync event
FPlatformProcess::ReturnSynchEventToPool(ThreadInitSyncEvent);
ThreadInitSyncEvent = nullptr;
return Thread != NULL;
}};
chenmozxh
when i double click uproject, a window pop up: MultiShootGames could not be compiled, Try rebuilding from source manually. i compile in vs2022, the error is:
Build started... 1>------ Build started: Project: MultiShootGame, Configuration: Development_Editor x64 ------ 1>Using bundled DotNet SDK 1>Log file: C:\Users\xxx\AppData\Local\UnrealBuildTool\Log.txt 1>Using 'git status' to determine working set for adaptive non-unity build (D:\MultiShootGame). 1>Creating makefile for MultiShootGameEditor (no existing makefile) 1>Parsing headers for MultiShootGameEditor 1> Running UnrealHeaderTool "D:\MultiShootGame\MultiShootGame.uproject" "D:\MultiShootGame\Intermediate\Build\Win64\MultiShootGameEditor\Development\MultiShootGameEditor.uhtmanifest" -LogCmds="loginit warning, logexit warning, logdatabase error" -Unattended -WarningsAsErrors -abslog="C:\Users\xxx\AppData\Local\UnrealBuildTool\Log_UHT.txt" -installed 1>Reflection code generated for MultiShootGameEditor in 6.0800228 seconds 1>Waiting for 'git status' command to complete 1>Terminating git child process due to timeout 1>Building MultiShootGameEditor... 1>Using Visual Studio 2022 14.32.31332 toolchain (D:\Microsoft\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326) and Windows 10.0.19041.0 SDK (C:\Program Files (x86)\Windows Kits\10). 1>Determining max actions to execute in parallel (10 physical cores, 12 logical cores) 1> Executing up to 10 processes, one per physical core 1> Requested 1.5 GB free memory per action, 2.97 GB available: limiting max parallel actions to 1 1>Building 7 actions with 1 process... 1>[1/7] Compile SharedPCH.Engine.ShadowErrors.cpp 1>[2/7] Resource Default.rc2 1>[3/7] Compile Module.MultiShootGame.gen.cpp 1>[4/7] Compile Module.MultiShootGame.cpp 1>D:\MultiShootGame\Source\MultiShootGame\GameMode\MultiShootGameGameMode.cpp(93): warning C4996: 'UWorld::GetPawnIterator': The PawnIterator is an inefficient mechanism for iterating pawns. Please use TActorIterator instead. Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
1>D:\Epic Games\UE_5.0\Engine\Source\Runtime\Core\Private\Windows\WindowsRunnableThread.h(33): error C2760: syntax error: '::' was unexpected here; expected 'id-expression'
hoping your reply and help, thx