search

6758-Project / hockey

0 stars 0 forks source link

Simple Visualizations: Code #15

Closed JakeColor closed 2 years ago

JakeColor commented 2 years ago

For more detail, see linked issue.

salelkafrawy commented 2 years ago

Looks good and running. I just have an issue when I run it with Jupyter lab (even if I opened it from the hockey directory I get that I'm at '/home/sara/Downloads/hockey/notebooks' when I run pwd

TimkLee commented 2 years ago

I have a quick question regarding limiting the allowed distance. Wouldn't that formula give us a circle? Or perhaps I have mistaken the coordinates?

image

STANDARDIZED_GOAL_COORDINATES = (89, 0)
MAX_ALLOWED_DISTANCE = ((89-25)**2 + (41-0)**2)**(.5)  # only consider shots within offensive zone (25 = blue line coordinate)
round(MAX_ALLOWED_DISTANCE)
JakeColor commented 2 years ago

thanks for your comment @TimkLee , I was overthinking it. simplified to coordinate_x >= 25 :)