search

6758-Project / hockey

0 stars 0 forks source link

M2 baseline model update #38

Closed TimkLee closed 2 years ago

TimkLee commented 2 years ago

intermediate pull request. Updated the graphs layouts, added the random baseline, and separated some functions to create the utils.py. Working on adding model registration next.

Visual Summary - Simple Logistic Regressions

TimkLee commented 2 years ago

Updated plot.

Visual Summary - Simple Logistic Regressions

TimkLee commented 2 years ago

One last thing: the x axes of the positive proportion and positive rate curves should be inverted, i.e. increasing and decreasing from left to right respectively.

This was working for me, but the plot you show in the PR descrip does not have this inversion.

Can you check that you're in the conda env + are using matplotlib 3.4.3?

Strangely, I have to manually set it. ax.set_xlim([100.05, -0.05]). The invert code l, r = ax.get_xlim() ax.set_xlim(r, l) # inverts percentile curves does not work for me.