6758-Project / hockey

0 stars 0 forks source link

Give it your best shot - Neural Network/MLP Exploration #42

Closed TimkLee closed 2 years ago

TimkLee commented 2 years ago

Hello,

Here are the files for the NN exploration.

In this PR, you will find:

TimkLee commented 2 years ago

NN Training

The combined NN_train script looks good! Nice work. Way to stick w/ it

Now to make this PR look sharp before merging, delete the other NN training scripts from the branch via git rm.

Generating Figures

R.e. generate_figures_mod/NN_Plot_Gen, why didn't you just modify the original generate_figures utility script?

I suggest modifying the original script by

  1. making the experiment_prediction_filenames an argument as agreed
  2. Calling generate_adv_model_figures twice in the if name = main block, once with the NN group of filenames and again with the xgboost group of filenames

Also remember to remove no-longer necessary scripts (again via git rm)

Outdated files removed and generate_adv_model_figures updated.