search

67P / hubot-incoming-webhook

Accept incoming Webhooks to write messages to a room/channel
9 stars 8 forks source link

Allow for messages with attachments #4

Closed RobinJayaswal closed 5 years ago

RobinJayaswal commented 7 years ago

Thanks for this library, super helpful. One problem is that you cannot send messages with attachments with it since you only send if its a string or an array. This quick fix makes it so you can send structured messages.

ps. right now it is actually possible, you simply have to create your structured message, then wrap it in an array before sending it in a POST request.

raucao commented 7 years ago

Thanks!

Looks like a simple enough change to me.

I'd be interested to know which adapter you're using that supports objects as messages. Also, it'd probably be nice for other users to document that in the README, too. Perhaps under "Usage" with an example of how you post an attachment.

raucao commented 5 years ago

Closing this, as it's been two years without response.

@RobinJayaswal Thank you for the PR, and feel free to open a new one, of course!