search

67P / hubot-incoming-webhook

Accept incoming Webhooks to write messages to a room/channel
9 stars 8 forks source link

Add UptimeRobot support #7

Closed gregkare closed 6 years ago

gregkare commented 6 years ago

Also move the generic hook to its own file

Closes #5

I have used the ent npm module to decode the HTML, I'm open to another module if you know one

gregkare commented 6 years ago

It needs HTML decoding because for some reason UptimeRobot encodes special characters (including parentheses) as HTML. The query string decoding is done by hubot, so no need for a library for that

gregkare commented 6 years ago

I have addressed the comments in the commits above

raucao commented 6 years ago

@gregkare You think you'd be able to find out how to test Hubot HTTP endpoints, and set up some tests for what we have so far? I believe it would make it much easier to add more hooks for other services from here on...

gregkare commented 6 years ago

Sure! I was thinking about that, I'm on it

gregkare commented 6 years ago

Tests are running on Travis now, and they're green!