search

67P / hubot-kredits

Kosmos Kredits chat/service integrations
https://wiki.kosmos.org/Kredits
MIT License
2 stars 1 forks source link

Create contributions instead of proposals #27

Closed raucao closed 5 years ago

raucao commented 5 years ago

Also watch for contributions added and log them.

closes #26

bumi commented 5 years ago

related to the potential noce issue: https://github.com/ethers-io/ethers.js/issues/319

raucao commented 5 years ago

I think this is ready to merge, so we can start using it with the new contracts.

I opened #28 for fixing the actual nonce issue.

bumi commented 5 years ago

but that "fix" does not block the http request?

raucao commented 5 years ago

Nope, see the lines where I changed it to not wait for the promise to resolve.

bumi commented 5 years ago

was wondering because of the await before... all that JS magic... :boom:

raucao commented 5 years ago

There's no await for the handler function before returning the 200. That was wrapped in a .then function, which I removed. For example:

https://github.com/67P/hubot-kredits/blob/dcbce66796669c96d931a70f0f2e3ba52437af31/integrations/github.js#L173-L174

raucao commented 5 years ago

Oops, I missed that comment.