Propose Kredits for code reviews

67P / hubot-kredits

Kosmos Kredits chat/service integrations

https://wiki.kosmos.org/Kredits

MIT License

2 stars 1 forks source link

Propose Kredits for code reviews #49

Closed raucao closed 3 years ago

raucao commented 4 years ago

On GitHub and Gitea, the reviewers should also get kredits (at least for medium/large contributions).

raucao commented 4 years ago

Documenting ideas we discussed so far:

Collect reviews over a period of time, e.g. one week, then create a single contribution for all reviews on merged PRs from that period
When one of the reviewers is also assigned to the PR, it means they have done more work on it over time, so they should earn either the full amount, or something between full and review amount.

raucao commented 4 years ago

@67P/core @67P/collaborators What do you think would be a good default kredits amount as percentage of the overall amount? (Keep in mind that one should be able to switch from giving review kredits to assigning a co-author.)

galfert commented 4 years ago

I think something like 20% might be a good number to start with.

raucao commented 4 years ago

Note from weekly call: @bumi, @gregkare, @skddc agree that it's a good number to start with.

galfert commented 3 years ago

So far I'm able to accumulate all reviews and the corresponding kredits for a given timeframe.

What should we put in the details of the contribution entry? Just the list of the pull request URLs or all of the payload data for every review?

raucao commented 3 years ago

List of URLs seems enough to me. Ideally we can turn it into separate contribution objects in IPFS later, once the kredits API wrapper supports that.