search

67P / hubot-kredits

Kosmos Kredits chat/service integrations
https://wiki.kosmos.org/Kredits
MIT License
2 stars 1 forks source link

Zoom integration #53

Closed bumi closed 4 years ago

bumi commented 4 years ago

closes #34

raucao commented 4 years ago

By the way, I just checked Rinkeby kredits, and none of our profiles have Zoom display names stored yet...

bumi commented 4 years ago

Yes, we need to collect all the zoom names. but we also need to test that four our kosmos call we get the correct participants.

raucao commented 4 years ago

but we also need to test that four our kosmos call we get the correct participants.

Not sure what you mean by "test". The participants will only ever be whatever their current Zoom display name is. Hence, the integration needs to ignore non-existing ones I believe. It will be a normal situation to not have all participants use a name, or have the right in their profile (or have a profile at all).

Edit: I also forgot to comment on the code: we established that re-connects add the same user multiple times to the array of the Zoom call object, so we need to use unique values in order to prevent multiple contributions from being created.

bumi commented 4 years ago

I could not test the full integration yet, because I can not get data from the past meeting participants endpoint. that's for paid plans only and I had issues with the JWT. That's what we need to pair on using the kosmos zoom account.

raucao commented 4 years ago

Ah, OK. Got it.

raucao commented 4 years ago

Dang, it slipped through my review that the documentation for this feature was missing in the README. (If it's not documented, it's not a feature.)

Edit: created #57 for it.