67P / hyperchannel

Kosmos Chat for the Web
Mozilla Public License 2.0
20 stars 3 forks source link

Handle channel user list for XMPP #130

Closed galfert closed 6 years ago

galfert commented 7 years ago

Closes #127

This queries for the room attendance list when joining a new room and handles the corresponding response from Sockethub.

It needs the implementation for Sockethub XMPP platform, which I created a PR for at sockethub/sockethub-platform-xmpp#15

Right now this only seems to work properly when connected to XMPP alone, but not when also connected to IRC. I think this is related to the issue reported at sockethub/sockethub-platform-irc#22, in which @skddc already suspected it might not just be an IRC issue but a general multiple connections issue.

raucao commented 6 years ago

The multiple-connections issue has been fixed!

raucao commented 6 years ago

@galfert See my last comment. This could actually work now...

galfert commented 6 years ago

I shall give it a try again.

galfert commented 6 years ago

While I can be connected to multiple IRC servers at the same time now, it still doesn't work with XMPP. Nothing seems to work when also connected to an IRC server. Although there seem to be no explicit error messages either.

When just connecting to a XMPP server alone, getting the channel user list works. My PR to sockethub-platform-xmpp, that was needed for this PR to work, has been merged. So I'm removing the [WIP]. I'll file a separate issue to sockethub for the multiple connections issue.

galfert commented 6 years ago

While I can be connected to multiple IRC servers at the same time now, it still doesn't work with XMPP.

I just tried again with @silverbucket's new feature/rework-connection-handling branches and with those I was actually able to connect to both IRC and XMPP at the same time \o/