search

67P / hyperchannel

Kosmos Chat for the Web
Mozilla Public License 2.0
20 stars 3 forks source link

First tap on channels doesn't register when opened via swipe #153

Open raucao opened 5 years ago

raucao commented 5 years ago

I always found the channel nav to be a bit weird, and today I found out why: in my installed PWA on Android (via Chrome), I have to tap twice in the channel list to actually switch to a channel (or register any taps for that matter), but only when I open the channel list via swipe. When I tap the header to open the list, the first tap works.

fsmanuel commented 5 years ago

@skddc Maybe a focus issue?

raucao commented 5 years ago

@fsmanuel Could be. Want to check if the same issue exists on iOS or not?

fsmanuel commented 5 years ago

I don’t have it on iOS.

Am 23.01.2019 um 01:34 schrieb Sebastian Kippe notifications@github.com:

@fsmanuel Could be. Want to check if the same issue exists on iOS or not?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

raucao commented 5 years ago

Just open https://hyperchannel.kosmos.org/ in Safari on there and you can immediately test. :)

fsmanuel commented 5 years ago

Haha. Sorry. I don’t have the behavior you described. Everything works as expected. Swipe -> tap -> animation and the channel is loading.

Am 23.01.2019 um 01:54 schrieb Sebastian Kippe notifications@github.com:

Just open https://hyperchannel.kosmos.org/ in Safari on there and you can immediately test. :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

raucao commented 5 years ago

So it's an issue with the swiping library and Chrome it seems.

raucao commented 5 years ago

I tested again, and have news: it might actually be the same issue on iOS, because it actually only happens when you tap too quickly. If you wait for about a second after swiping, it will work, but if you tap immediately (even though the animation should already be finished), it won't register the tap.

@fsmanuel Could you try again with this new information and see if you can reproduce the issue?

galfert commented 5 years ago

I can't reproduce it on iOS either. Even when tapping while the animation is still in progress, it still switches the channel.

raucao commented 5 years ago

Thanks. We'll have to investigate on Android then. Desktop Chromium in mobile mode might work for reproducing.