search

67P / hyperchannel

Kosmos Chat for the Web
Mozilla Public License 2.0
20 stars 3 forks source link

New activity-streams URL in Sockethub 3.0 #161

Closed gregkare closed 5 years ago

gregkare commented 5 years ago

I deployed a test instance of sockethub 3.0.1 using the latest node LTS version (2.0.5 doesn't work with node 10)

In Sockethub 3.0, the activity streams JS file is available under https://sockethub.kosmos.org:10550/activity-streams.min.js instead of https://sockethub.kosmos.org:10550/activity-streams.js, so hyperchannel doesn't work anymore

Apart from that hyperchannel appears to work with sockethub 3

gregkare commented 5 years ago

Wouldn't it make more sense to vendor these dependencies into hyperchannel instead?

raucao commented 5 years ago

No, because Hyperchannel cannot know which version of Sockethub you are going to connect. Also, Sockethub should provide unminified client code, as it did before.

gregkare commented 5 years ago

OK, I'll open an issue in sockethub then

Edit: sockethub/sockethub#237

gregkare commented 5 years ago

This was fixed by #165