search

67P / hyperchannel

Kosmos Chat for the Web
Mozilla Public License 2.0
20 stars 3 forks source link

Partial message rendering #167

Closed galfert closed 5 years ago

galfert commented 5 years ago

Closes #92

This displays only the last 30 messages when opening a channel to improve the rendering speed. More messages are then displayed when scrolling up to the top of the page.

This PR is a replacement for #162 and should fix all the remaining problems that PR still had.

The code is also much cleaner/simpler. It uses the scrolling-observer component introduced in #166 both for rendering more messages when scrolling up, as well as enabling/disabling automatic scrolling when scrolling down.

raucao commented 5 years ago

There's still a small issue with it suddenly jumping up a bit when scrolling through long histories. But it's such a huge improvement over what we have, that I'd say let's merge it and do shaping afterwards, in separate PRs.

Great job, @galfert!

group-five