search

67P / hyperchannel

Kosmos Chat for the Web
Mozilla Public License 2.0
20 stars 3 forks source link

Update Ember and octanify all the things #202

Closed galfert closed 4 years ago

galfert commented 4 years ago

Closes #184

This updates Ember to the latest stable version (3.17) and updates the whole codebase to use the latest and greatest of Ember Octane (e.g. native JS classes, decorators, angle bracket components, ...)

raucao commented 4 years ago

Wow, this one is massive. :eyes:

raucao commented 4 years ago

Everything regarding chat itself seems to be working perfectly fine. However, I get an exception when trying to add a space from a preset:

Error: Assertion Failed: You must pass a function as the `fn` helpers first argument, you passed saveSpace

I remember that I tried upgrading the settings to Octane and then gave up, because I couldn't make it work. I'm not sure if we should spend much time on fixing the current settings, which are basically just a hack so that you can add more spaces at all. So maybe we should rather talk about how we want them to actually work and then spend time on a new implementation immediately.

I definitely have a lot of thoughts on this that I haven't documented yet. @galfert Happy to jump on a call about it anytime.

galfert commented 4 years ago

The error itself was pretty easy to fix. I hadn't tried that part of the app myself yet, so I found a few other mistakes and fixed those as well. Now it should at least work the same as before.

That doesn't prevent us from talking about your thoughts on better settings of course :)

raucao commented 4 years ago

OK, great!

raucao commented 4 years ago

5d15fca4_Screenshot from 2020-04-01 11-36-55

Hooray!

raucao commented 4 years ago

Missed one thing here still. ^^