search

67P / hyperchannel

Kosmos Chat for the Web
Mozilla Public License 2.0
20 stars 3 forks source link

Fix user settings in localStorage #220

Closed raucao closed 3 years ago

raucao commented 3 years ago

Switch from ember-local-storage to localForage (and thus also IndexedDB by default).

Contains a generic function which allows to extend a defaultValues object in the service with more default data to be set for empty local storages.

Testing this manually is possible by just seeing if loading the app from the root URL redirects to the last channel you had open or not (should not do on master, but should do with this fix).

fixes #219

fsmanuel commented 3 years ago

Totally confused. You didn't even remove "ember-local-storage": "^1.7.2", from the package.json and just added a new addon and still have that crazy diff in package-lock.json. When we build the kredits wrapper I was discussing with @bumi if one should get more kredits if the PR removes more than it adds. As an insentive to produce better software... =) That would be a big one for you @raucao ...

raucao commented 3 years ago

CodeClimate is throwing a fit, but I disagree with it about the complexity of that function.