search

67P / hyperchannel

Kosmos Chat for the Web
Mozilla Public License 2.0
20 stars 3 forks source link

Replace custom modal implementation #251

Closed galfert closed 2 years ago

galfert commented 2 years ago

This replaces our custom modal implementation using liquid-fire and ember-elsewhere with https://github.com/simplabs/ember-promise-modals.

Liquid-fire is not maintained anymore for quite a while now. Also it was the last dependency of Hyperchannel that required jQuery.

The new modal library is much simpler to use and uses pure CSS animations.

During testing I noticed that the left menu was overlapping the settings modal on mobile screens. Changing some z-index styles fixed that issue as well.

galfert commented 2 years ago

Fixed the merge conflict and checked out your changes. New animations look much better indeed