Update kredits-contracts

67P / kredits-web

Kredits Web UI

https://kredits.kosmos.org

6 stars 2 forks source link

Update kredits-contracts #103

Closed bumi closed 5 years ago

bumi commented 5 years ago

This updates kredits-contracts to the latest 5.x release which contains the details for the weltempfaenger rinkeby "production" release.

once merged, we should deploy kredits-web

ToDo:

[x] release new kosmos-schemas and use here.

bumi commented 5 years ago

can someone help me with the failing test? I guess this has something to do with the changed schema validations but I don't really know how they affect that test.

raucao commented 5 years ago

The arguments are definitely not valid according to the latest schema (missing date for example). But I'm wondering why we would test this in kredits-web in the first place? This is a test for the contracts library, not the Web UI.

fsmanuel commented 5 years ago

But I'm wondering why we would test this in kredits-web in the first place?

Because we had and have no test in kredits-contracts so we put it here.

This is a test for the contracts library, not the Web UI.

Agreed!

fsmanuel commented 5 years ago

@bumi muhahahaha

fsmanuel commented 5 years ago

I think we can remove the kosmos-schemas dependency now.

raucao commented 5 years ago

Updated everything and successfully tested that it works with production contributors now.