Closed bumi closed 5 years ago
raucao
commented
5 years ago I completely disagree with this being added to kredits-web. We actually discussed this and agreed that it needs to be fixed in the wrapper, so that clients don't have to repeat all that implementation, and also because kredits are integers in the first place.
(Btw, @bumi, I'm trying to talk on XMPP, but it seems like you're not reading the dev channel.)
bumi
commented
5 years ago see that PR in kredits-contracts.
on the ERC20 tokens we can not make sure that kredits are always full integers.
in those lists here in kredits-web we must display the contribution kredits - not the token balances.
raucao
commented
5 years ago on the ERC20 tokens we can not make sure that kredits are always full integers.
How so? What good is an ERC20 config property for decimal points, if we cannot configure and/or handle it the way we want? (This is not a good place to discuss that, btw. It would really be helpful to either chat or call about it.)
bumi
commented
5 years ago With this PR kredits-web with the current contracts would work. We could deploy that to have a working version? With the new PRs in kredits-contracts and an upcoming PR here we could switch to showing the earned kredits from contributions and not the token balances. (which imo would be more what we want in the UI right now).
then we need to plan on how we show the different balances.
raucao
commented
5 years ago I don't think anyone objected to the merging of this PR.
raucao
commented
5 years ago Kredits label missing btw.
bumi
commented
5 years ago does it create enough value for a kredits label :D
Kredits are stored on the Token contract as uint256 / bignumbers with 18 decimal points. Just like Ether and required by the ERC20 standard. So we need to work with bignumbers and format a bignumber value here.