search

67P / kredits-web

Kredits Web UI
https://kredits.kosmos.org
6 stars 2 forks source link

Contribution details #140

Closed raucao closed 4 years ago

raucao commented 4 years ago

Adds a details pane for contribution records, similar to contributor profiles.

Just the basic details for now. Can be extended with all kinds of data, links, icons, etc. from here on.

Screenshot from 2019-07-17 12-58-06

closes #121

galfert commented 4 years ago

Code looks alright and everything works.

One thing I noticed though: when scrolling down and selecting a contribution further down, you can't see the contribution details, because those are still at the top of the page.

Wouldn't it be better to show the contribution details right below the selected contribution?

raucao commented 4 years ago

Wouldn't it be better to show the contribution details right below the selected contribution?

No. The solution is to have the details pane be fixed in position when scrolling down, but that's a major layout problem, which I wasn't able to solve quickly. This is just the basic implementation for contributions details, as described above. All improvements from here on are separate PRs (and btw, anyone can help with them).

galfert commented 4 years ago

👍