search

67P / kredits-web

Kredits Web UI
https://kredits.kosmos.org
6 stars 2 forks source link

Sign up via GitHub #142

Closed raucao closed 5 years ago

raucao commented 5 years ago

As discussed, only adding routes and UI for the signup flow.

Also contains a drive-by fix for a small bug with the account name, after extracting it to a component. See commits for more info.

galfert commented 5 years ago

Wired everything up to work with 67P/hubot-kredits#41.

I think the only thing missing is showing a success message or transitioning to a success page after the contributor has been created (see https://github.com/67P/kredits-web/pull/142/files#diff-9f12217253bedb83186b9295ac7b61d2R46).

raucao commented 5 years ago

As long as I haven't missed anything, I think this is good to merge.

Anyone wants to confirm? Kredits label OK?

galfert commented 5 years ago

Yes, I think all is good.

raucao commented 5 years ago

Where does the sudden merge conflict come from? :thinking:

galfert commented 5 years ago

No idea. Haven't edited any CSS in a long time.