search

67P / kredits-web

Kredits Web UI
https://kredits.kosmos.org
6 stars 2 forks source link

Gracefully handle pending changes for contributions #159

Closed raucao closed 4 years ago

raucao commented 4 years ago

This adds the pending tx data to pending contributions (after adding or vetoing, until the tx is mined). It also disables the veto button while pending.

WIP until I've added the same for contributor additions/changes. Also, it's branched out from #156, which hasn't been merged yet.

closes #120

raucao commented 4 years ago

Looking for reviews now. Doing contributors in a separate PR.

raucao commented 4 years ago

@galfert Does your comment mean that you took this for a spin?

galfert commented 4 years ago

I only looked at the code. Besides my one comment it looked ok to me.

raucao commented 4 years ago

Could you please test it?

(If you still have trouble running this easily on your machine, then you need to tell us that. Everything should work in a way that it's very easy to test now.)

raucao commented 4 years ago

Note to whoever didn't use this feature before: in order to get longer, more realistic confirmation times from your dev chain, you can add block-time to the devchain npm script, like so:

-    "devchain": "aragon devchain --port 7545",
+    "devchain": "aragon devchain --port 7545 --block-time 20",
galfert commented 4 years ago

I tested the PR and confirmed everything to work.

I fixed the merge conflict and changed the confirmation-status helper to detect the pending changes. I also removed the volatile() property modifier everywhere, as it was already throwing a deprecation warning.