search

67P / kredits-web

Kredits Web UI
https://kredits.kosmos.org
6 stars 2 forks source link

Upgrade Ember and deps to 3.18/Octane #186

Closed raucao closed 4 years ago

raucao commented 4 years ago

This PR doesn't upgrade components to be Glimmer components yet. It's already big enough as it is.

@galfert I'm not sure if you saw my chat message, but when you look at the tests you can find one helper failing (due to some kind of observer issues), and that one failure also seems to break the entire run loop of the Ember app when using it normally, thus freezing the app in place when it hits (which is when you look at contribution details). Hence the WIP.

I also removed all code relating to proposals on the way, as we're not using them at all at the moment. Thus, dragging the code along through big upgrades like this one didn't make sense to me. We can always retrieve it from Git whenever we need it again.

galfert commented 4 years ago

Haha, now I wonder how it ever NOT caused an exception :) There was a typo in the property name in the function that removes the observer. I guess older Ember versions kept track of existing observers in a different way that didn't fail when trying to remove a non-existent observer.

raucao commented 4 years ago

wowitworked

raucao commented 4 years ago

@galfert Thanks!

So this is ready to review/merge then.

galfert commented 4 years ago

I'm already reviewing it.

raucao commented 4 years ago

Thanks!

(I cannot reproduce the misalignment of the amounts.)

galfert commented 4 years ago

(I cannot reproduce the misalignment of the amounts.)

Looks ok here now, too. I think it was the missing contribution-status class.