search

67P / kredits-web

Kredits Web UI
https://kredits.kosmos.org
6 stars 2 forks source link

Update to kredits-contracts 6.0 and ethers 5.x #194

Closed bumi closed 2 years ago

bumi commented 3 years ago

Using the latest kredits-contracts and ethers.js libraries.

bumi commented 3 years ago

Do we have any known issues with the handleTransfer callback? on master I get a "Cannot read property 'decrementProperty' of undefined" and in this PR the toNumber causes an overflow. https://github.com/67P/kredits-web/blob/e047cc45ba4d1b8a6ef3518cd9350524e16ed19f/app/services/kredits.js#L485-L494

raucao commented 3 years ago

I don't know the issue from before, but it may well have been there.