67P / kredits-web

Kredits Web UI
https://kredits.kosmos.org
6 stars 2 forks source link

Introduce budget, reimbursements for expenses #195

Closed raucao closed 3 years ago

raucao commented 3 years ago

This is a big one. It isn't linked from the dashboard yet, but you can browse to /budget and propose reimbursements from there.

Requires https://github.com/67P/kredits-contracts/pull/198 Refs 67P/kredits-contracts#48

To do

raucao commented 3 years ago

I just finished the functionality of the PR, so there are just the linter errors left. You can test it on your machines now.

There's one known issue, which won't be much of a problem in a production: a race condition, when your tx confirms within the loading of the reimbursement list after pressing the submit button on the reimbursement form. I'm not sure how to handle that, and it doesn't break anything in the unlikely case that you see this in production. Just reload the page and all is good, due to the caching and syncing logic.

I would recommend to always add a block time to your local devchain when testing UI anyway, to not get the wrong feel for how things work in production: e.g. npm run devchain -- --block-time 5.

raucao commented 3 years ago

All done and ready to merge from my point of view.

raucao commented 3 years ago

@galfert Did you see my replies? I just merged the corresponding contracts PR, so it'd be great if we can merge this one as well now.