search

67P / kredits-web

Kredits Web UI
https://kredits.kosmos.org
6 stars 2 forks source link

Batch voting #73

Closed raucao closed 5 years ago

raucao commented 6 years ago

Continuation of #62. Rebased branch on master, refactored form styles, updated deps.

Apparently the deployed contract on Kovan doesn't support batch voting yet, or has a bug related to it. I can do transactions for it, but they fail with a contract error.

fsmanuel commented 6 years ago

👍

bumi commented 6 years ago

@fsmanuel as you worked on it, can you review the latest status and merge it. The kovan contract will at some point support it, nothing (ok, maybe updating kredits-contracts) needs to change for that here.

raucao commented 6 years ago

Thing is, we're kind of close to not having any voting at all, and then single vetos will be much more common than batch ones. So I think this branch would need to revert using the +1 buttons as selectors and maybe add actual option fields for rows that one can select.

fsmanuel commented 6 years ago

@skddc I'm not sure if I get what you say. Do you want real (ugly) checkboxes? We can change the appearance of the +1 buttons to whatever we want. We just need to talk about how they should look like. Anyway let me know if I should rebase and continue working on it or how we proceed.

raucao commented 6 years ago

No, I want to be able to use the +1 buttons for a single veto/vote, instead of having to press one button, then scroll down, then press another button. The checkboxes can be unstyled and ugly (although I have already designed nice checkboxes; see adding a contributor e.g.).

It's an alpha app, and this is all going to change considerably rather soon anyway. I think we can live with some ugly checkboxes, when that doesn't impact UX negatively at the moment.

So, with that in mind, rebase or not depends on what's easier in terms of adapting code. Could be easier to just copy some bits to a new branch off of master.

raucao commented 5 years ago

Closing this one for now, because we won't have voting on contributions in the beginning and the UI has to change for that everywhere.