search

67P / kredits-web

Kredits Web UI
https://kredits.kosmos.org
6 stars 2 forks source link

Change messaging if metamask not installed #79

Closed homtec closed 5 years ago

homtec commented 6 years ago

Now: "Loading data from Ethereum..." Expected: instructions how to proceed

raucao commented 6 years ago

Actually, if Metamask is not installed it should just load the data from the network and show you the dashboard without any member features active.

Most likely an issue with IPFS. @gregkare was playing around with the IPFS nodes just yesterday and this morning, trying to set up a cross-datacenter cluster for better connectivity and reliability. Sometimes the objects load when you retry a second time.

homtec commented 6 years ago

Even better

Sebastian Kippe notifications@github.com schrieb am Mi., 8. Aug. 2018, 22:46:

Actually, if Metamask is not installed it should just load the data from the network and show you the dashboard without any member features active.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/67P/kredits-web/issues/79#issuecomment-411546568, or mute the thread https://github.com/notifications/unsubscribe-auth/AAumkLNzygZ5Zy56FKxiXc0AYuvGoI9sks5uO04vgaJpZM4V0fRy .

raucao commented 6 years ago

I might have written it in a way that's not clear: the current implementation should already work the way I described is what I meant. :)

homtec commented 6 years ago

Got it. Maybe it took some while. In this case a loading indicator would be helpful. Its working now. Thx

raucao commented 6 years ago

There's a pulsing loading indicator as well as the text you pasted. Was there no pulsing comet on the page above the text when you saw it?

homtec commented 6 years ago

There was, but I didn't recognized it as a loading indicator. I think it crashed somehow so there was no progress. If it's only expected to cover ~5sec I think its ok.

In general: What do you think to define the current "no metamask installed" flow as the default behavior? Have the "sign-in" via Metamask optional or ask if the user wants to make a transaction.

raucao commented 6 years ago

It's actually optional, just not with nice UI. You can just click cancel in the dialog and proceed without opening the wallet.

homtec commented 6 years ago

Yes, but its not the same. My suggestion is to remove any metamask interaction at this step to reduce any potential obstacle.

raucao commented 5 years ago

This one is obsolete, because the alert doesn't exist anymore, and there's a whole new Metamask connect UI for allowing access to the account now.