6WIND / zrpcd

Zebra/Quagga RPC communicator to handle Quagga framework from a SDN controller
GNU General Public License v2.0
5 stars 10 forks source link

support for sles-12 and redhat7 #21

Closed pguibert6WIND closed 7 years ago

pguibert6WIND commented 7 years ago

hello @maheshloni , i would like you to review this pull request.

since i replace facter tool with lsb_release.

regarding the usage of facter, it is a mess to install it on sles-12. that is why we want to propose using lsb_release instead.

Can I ask you to check if lsb_release is installed on other distribs ? Thanks

maheshloni commented 7 years ago

Hi Philippe, lsb_release command doesn't work in Centos7. More over CSIT accepts only using facter command (standard command)

Note: CSIT suggested standard command to fetch OS and its version from various flavors of operating system instead of using lsb_release or uname -a

I think its better to add one more option for sles12 : zypper install facter by appending in the below line #60 : apt-get install -y facter || yum -y install facter || < sles12 command to install facter> ;

and for redhat os : yum command will work for installing the facter . Can you please check on sles12 whether zypper install facter is works or not . If you know proper syntax to install the facter command in sles12 , then its better to add it.

pguibert6WIND commented 7 years ago

Hi @maheshloni , a new rework of the script is available here. please review.

pguibert6WIND commented 7 years ago

Hi @maheshloni , please review the pull request. some update has been done.

pguibert6WIND commented 7 years ago

use following command to test:

./pkgsrc/dev_compile_script.sh -p -d -b -v 5

xiaofeng6WIND commented 7 years ago

Hi @maheshloni , please review new patches:

Thanks.

xiaofeng6WIND commented 7 years ago

Hi @pguibert6WIND @maheshloni , Please review the patches:

  1. pkgsrc: package c-capnproto
  2. pkgsrc: package thrift
  3. pkgsrc: package zmq