6c65726f79 / Transmissionic

Remote for Transmission Daemon
MIT License
425 stars 30 forks source link

Fix Regression When Adding Torrent Files #1351

Open apsoyka opened 1 year ago

apsoyka commented 1 year ago

At some point, the parse-torrent dependency was upgraded; the new version of this dependency relies on another dependency named uint8-util which relies on the WebCrypto API for message digest functions.

Unfortunately, the WebCrypto API is only available in secure contexts (HTTPS or localhost). This is likely why the regression was not caught sooner, because a developer would have to go out of their way to load the web app in an insecure context in order to experience the bug.

This PR reverts to the previous version of the offending dependency, which appears to solve the problems users are experiencing with adding torrent files from local filesystem or by URL.

Resolves https://github.com/6c65726f79/Transmissionic/issues/1309, resolves https://github.com/6c65726f79/Transmissionic/issues/1340.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information