6eer / uniswap-sushiswap-arbitrage-bot

Two bots written in JS that uses flashswaps and normal swaps to arbitrage Uniswap. Includes an automated demostration.
MIT License
586 stars 264 forks source link

Are the parameters to computeProfitMaximizingTrade correct? #24

Open tthil opened 1 year ago

tthil commented 1 year ago

The call to the smart contract function computeProfitMaximizingTrade takes 4 parameters (sReserve0, sReserve1, uReserve0, uReserve1) The parameter list in the smart contract is defined as
computeProfitMaximizingTrade( uint256 truePriceTokenA, uint256 truePriceTokenB, uint256 reserveA, uint256 reserveB

My question is if sReserve0 and sReserve1 really are truePriceTokenA and truePriceTokenB?

0xNagato commented 1 year ago

Were you able to improve this?

tthil commented 1 year ago

Hi,

No, I moved on. I felt like this repo is dead and more of a test.

//Thomas

On 17 Nov 2022, at 00:53, 0XFEZ @.***> wrote:

Were you able to improve this?

— Reply to this email directly, view it on GitHub https://github.com/6eer/uniswap-sushiswap-arbitrage-bot/issues/24#issuecomment-1317424592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPF26ZPJQJF7BA63BSRBBTWIUNSJANCNFSM6AAAAAAQV6VQJQ. You are receiving this because you authored the thread.

0xNagato commented 1 year ago

Did you have any luck finding any good ones? I'm very stuck

tthil commented 1 year ago

I decided to dig deeper into by myself and build it from scratch as it is more to it than just the interaction with the smart contract.

//Thomas

On 17 Nov 2022, at 10:57, 0XFEZ @.***> wrote:

Did you have any luck finding any good ones? I'm very stuck

— Reply to this email directly, view it on GitHub https://github.com/6eer/uniswap-sushiswap-arbitrage-bot/issues/24#issuecomment-1318030169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPF265NXNDUBFILXCO6KGLWIWUJJANCNFSM6AAAAAAQV6VQJQ. You are receiving this because you authored the thread.

manzub commented 10 months ago

Hi Thomas, I do want to build it myself too but i need inspiration to build a more competitive bot joining this late