"mixins.scss" and "variables.scss" files aren't exist in the "sass" folder

AlexandrChazov commented 8 months ago

Describe the bug

Hello, I use "slickgrid" in "react" and unstalled it with "npm" When I try to import styles following the migration guide @import 'node_modules/slickgrid/dist/styles/sass/slick-alpine-theme.scss'; I receive SassError: "Can't find stylesheet to import". After opening file "node_modules/slickgrid/dist/styles/sass/slick-alpine-theme.scss" I noticed lack of files "mixins.scss" and "variables.scss" in the "sass" folder which it tries to import. As a workaround I can import styles from the "src" folder @import "node_modules/slickgrid/src/styles/slick-alpine-theme.scss" But I'm not sure whether it's correct.

Reproduction

npm install slickgrid in "index.scss" file try to import styles @import 'node_modules/slickgrid/dist/styles/sass/slick-alpine-theme.scss';

Which Framework are you using?

React

Environment Info

| Executable          | Version |
| ------------------- | ------- |
| React               | 17.0.2  |
| slickgrid           |  5.8.2  |
| TypeScript          |  4.7.4  |
| Windows             |   10    |
| Node.js             | 18.20.0 |
| npm                 | 10.5.0  |

Validations

[X] Follow our Code of Conduct
[X] Read the Wikis.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

ghiscoding commented 8 months ago

ah yeah that's a bug, I'm not sure why it doesn't copy all files, it should include the 2 files starting with underscore as well. It works in my other repo,

https://github.com/6pac/SlickGrid/blob/13f69c4e569e69354fbb379ffa673ade29505173/package.json#L65

oh wait, it seems that I'm not using the npm script but rather the external script from build.mjs and it looks like I excluded them from the build, I'm not sure why I've done that, it's an error from my part

https://github.com/6pac/SlickGrid/blob/13f69c4e569e69354fbb379ffa673ade29505173/scripts/builds.mjs#L163-L170

ghiscoding commented 8 months ago

should be fixed in v5.8.3

AlexandrChazov commented 8 months ago

Thanks a lot for fixing! It works now.

6pac / SlickGrid