6pac / SlickGrid

A lightning fast JavaScript grid/spreadsheet
https://github.com/6pac/SlickGrid/wiki
MIT License
1.82k stars 424 forks source link

fix: primary entry point to the program isn't set correctly #1008

Closed AlexandrChazov closed 5 months ago

AlexandrChazov commented 5 months ago

It's written in the package.json file that primary entry point has path "./dist/browser/index.js", but there is no such file there.

image

Although library works when I try to run integration tests with Jest for files which make import from node_module 'slickgrid' it complains Cannot find module 'slickgrid'

image

ghiscoding commented 5 months ago

ah yeah like I said I no longer use SlickGrid repo since I copied the same implementation into Slickgrid-Universal to be standalone, so yes you are correct we should link to the CJS version for Jest. The browser doesn't have to be linked since it's typically referenced as file directly (typically by CDN).

... so thanks, your assumption was correct.

ghiscoding commented 5 months ago

new release is out, cheers