6pac / SlickGrid

A lightning fast JavaScript grid/spreadsheet
https://github.com/6pac/SlickGrid/wiki
MIT License
1.82k stars 424 forks source link

Fix: Tweak setupColumnSort() to fix exception when col no longer exists #1016

Closed 6pac closed 4 months ago

6pac commented 4 months ago

Tweak setupColumnSort() to fix exception when a no longer existing column is in the sort list. Fixes #1015

ghiscoding commented 4 months ago

@6pac The PR looks good, also for your info, you were mentioning that it's harder to debug JS code now, however you can do it directly in the editor now (VSCode). See animated gif below for how I do it now and feel free to ask any questions.

Code_iuCExmqiyI

6pac commented 4 months ago

this fix is now ready to be pulled.