Simple Row Reordering example is not working

FireMuse commented 4 months ago

Describe the bug

[https://6pac.github.io/SlickGrid/examples/example9-row-reordering-simple.html]

The example for row reordering is not working.

Reproduction

Load https://6pac.github.io/SlickGrid/examples/example9-row-reordering-simple.html. Try to follow the instructions. It doesn't work.

Which Framework are you using?

Angular

Environment Info

| Executable          | Version |
| ------------------- | ------- |
| (framework used)    | VERSION |
| SlickGrid | VERSION |
| TypeScript          | VERSION |
| Browser(s)          | VERSION |
| System OS           | VERSION |

Validations

[X] Follow our Code of Conduct
[X] Read the Wikis.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

ghiscoding commented 4 months ago

The other example9-row-reordering is working, you can take a look at that one and perhaps you can contribute a fix to the simple one

ghiscoding commented 4 months ago

closed by PR #1042, the problem was that the Example wasn't properly requesting the drag column from the plugin, it was just a random column with drag icons and we can't simply do that. We really need to let the plugin create the drag column for us, we then get it from columns.unshift(rowMovePluging.getColumnDefinition()) and that will then work correctly

ghiscoding commented 3 months ago

Edit, I've now also fixed the drag row(s) to the recycle bin as well in the same example, and so dragging row(s) will now delete them from the grid.

6pac / SlickGrid