fix: add `nonce` grid option set the nonce value for CSP header

6pac / SlickGrid

A lightning fast JavaScript grid/spreadsheet

https://github.com/6pac/SlickGrid/wiki

MIT License

1.82k stars 422 forks source link

fix: add `nonce` grid option set the nonce value for CSP header #902

Closed JesperJakobsenCIM closed 10 months ago

ghiscoding commented 10 months ago

@JesperJakobsenCIM this looks good, I just have 1 requested change. Also please note that I changed the title of your PR because we follow Conventional Commits in order to automatically update our changelog.md files and for the GitHub release as well, in your use case I chose fix: ... because I don't want to create a minor version but I guess typically a feat: would be better but I want to release my other bug fix probably tonight and I don't want a minor version

ghiscoding commented 10 months ago

good to merge after the change I made, thanks for the contribution :)

ghiscoding commented 10 months ago

It's now available in v5.4.2 thanks again :)

ghiscoding commented 10 months ago

oh actually it's not available, I just noticed that you create the PR against the wrong branch 6pac:feat/drop-inner-html, so it's not released yet, I will create another PR to merge this to master branch as it should be. It will have to wait for a future release, I'm done with all my fixes so it's probably going to wait for a few more weeks.