search

6peterlu / BasisPeakMonitor

Enabling doctors to monitor patient health with the Basis Peak wearable tracker.
1 stars 1 forks source link

find a way to just not graph the -1 points #2

Open 6peterlu opened 8 years ago

6peterlu commented 8 years ago

it looks weird on the graph with all those extra spikes

ashleylau commented 8 years ago

The GSR graph still puts the scale from 0 to 10 even without the -1 points, but otherwise those points are skipped I believe. Also made a bargraph activity for calories and steps. Check it out.

6peterlu commented 8 years ago

awesome! did you push the code?

ashleylau commented 8 years ago

yep just now

On Mon, Mar 28, 2016 at 6:57 PM, 6peterlu notifications@github.com wrote:

awesome! did you push the code?

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/6peterlu/BasisPeakMonitor/issues/2#issuecomment-202665633

Stanford University | Class of 2019 B.S. Candidate | Electrical Engineering B.S. Minor Candidate | Computer Science

6peterlu commented 8 years ago

Okay, the bar graph activity looks good. I don't think the code you used to remove the -1 points is accurate though, since it just straight up removes the data point and shifts everything to the left. If this shift was negligible, this would be okay, but as you can see on the timescale on the bottom, for heartrate, the scale goes to 16 hours which is about 4 pm, but its 7 pm now. This means that a significant amount of data is being lost.