search

71 / BeatSinger

Beat Saber plugin for displaying floating lyrics while playing the game.
MIT License
45 stars 10 forks source link

Not currently working with BeatSaber 1.11.1 #17

Open ChipWolf opened 3 years ago

ChipWolf commented 3 years ago

Currently, the BeatSinger mod does not work with the latest version of BeatSaber. Please update the mod for compatibility with BeatSaber 1.11.1.

71 commented 3 years ago

Hey there,

Unfortunately I don't have a VR headset anymore so I can't debug this, but I can try porting it to the latest API. @Zingabopp has also offered to fix this, but there is another problem. The plugin uses Musixmatch to find lyrics using the API key of their desktop client. I believe this is fine because the API key is available publicly, this is an open-source project and no one is earning money from it, but accepting a bug bounty invalidates that last point.

With that in mind, please revoke that bounty you set (even though I'm very grateful that you offered one to start with). If you don't mind the lack of bounty, @Zingabopp, feel free to submit a PR. Otherwise, I'll try fixing it myself.

Zingabopp commented 3 years ago

I'd be fine doing the PR without the bounty.

71 commented 3 years ago

Alright, great! Please take a look at the new master. I fixed some typing errors related to the upgrade but I haven't been able to test my changes yet. I'll also take a look at the license.

ChipWolf commented 3 years ago

Revoked.